Add library dependency to node executable in rclcpp_components_register_node#3047
Merged
ahcorde merged 1 commit intoros2:rollingfrom Feb 2, 2026
Merged
Conversation
…er_node Fixes #2868 The executable created by rclcpp_components_register_node now depends on the library target, ensuring the library is rebuilt when the executable is rebuilt. Added SKIP_LIBRARY_DEPENDENCY option for cases where the plugin is provided by a different package. Signed-off-by: dbwls99706 <yujinhong3@gmail.com>
fujitatomoya
approved these changes
Jan 30, 2026
Collaborator
|
Pulls: #3047
|
ahcorde
approved these changes
Feb 2, 2026
|
I guess backporting this is a no-go as it changes behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2868
Description
The executable created by
rclcpp_components_register_nodenow depends on the library target, ensuring the library is rebuilt when the executable is rebuilt.As suggested by @sloretz in #2868, added
SKIP_LIBRARY_DEPENDENCYoption for cases where the plugin is provided by a different package.Changes
add_dependencies(${node} ${target})afteradd_executable()SKIP_LIBRARY_DEPENDENCYoption to opt-out of this behaviorIs this user-facing behavior change?
No
Did you use Generative AI?
Yes, Claude was used to identify the fix location and generate the implementation.