Skip to content

remove test_static_executor_entities_collector.cpp#3041

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/remove-test_static_executor_entities_collector
Jan 29, 2026
Merged

remove test_static_executor_entities_collector.cpp#3041
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/remove-test_static_executor_entities_collector

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Jan 28, 2026

Description

this test file is not compiled / used anymore.

Note

we can backport this to kilted and jazzy

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@fujitatomoya
remove test_static_executor_entities_collector.cpp
9f2a3c4 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 28, 2026 •
edited
Loading

Pulls: #3041
Gist: https://gist.githubusercontent.com/fujitatomoya/a9d559418338a89a522dcde0761ef753/raw/77a91f4227320cdd68d6b8987d1f930c6c15f782/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18055

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski
Copy link
Copy Markdown
Collaborator

jmachowinski commented Jan 28, 2026

This is odd, how is this still compiling without a change to CMakeLists.txt ? Is there some sort of auto generation going on ?

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 28, 2026

i think that simply this file is never compiled and used anymore... 💦 nobody realized this is just left over for a long time....

@fujitatomoya fujitatomoya merged commit db74697 into rolling Jan 29, 2026
2 of 3 checks passed
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 29, 2026

@Mergifyio backport kilted jazzy

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 29, 2026 •
edited
Loading

backport kilted jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 29, 2026
@fujitatomoya @mergify
remove test_static_executor_entities_collector.cpp (#3041)
6c76408 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit db74697)
@mergify mergify bot mentioned this pull request Jan 29, 2026
Merged
mergify bot pushed a commit that referenced this pull request Jan 29, 2026
@fujitatomoya @mergify
remove test_static_executor_entities_collector.cpp (#3041)
75703ff 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit db74697)
@mergify mergify bot mentioned this pull request Jan 29, 2026
Merged
fujitatomoya added a commit that referenced this pull request Jan 30, 2026
@mergify @fujitatomoya
remove test_static_executor_entities_collector.cpp (#3041) (#3045)
810ff6a 
(cherry picked from commit db74697)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Jan 30, 2026
@mergify @fujitatomoya
remove test_static_executor_entities_collector.cpp (#3041) (#3046)
eaa1db2 
(cherry picked from commit db74697)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@ahcorde ahcorde deleted the fujitatomoya/remove-test_static_executor_entities_collector branch February 2, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @jmachowinski @mjcarroll