Skip to content

fix wait_for_message for custom ros contexts#3021

Merged
ahcorde merged 1 commit intoros2:rollingfrom
rahatchd:fix/wait-for-msg-ctx
Jan 21, 2026
Merged

fix wait_for_message for custom ros contexts#3021
ahcorde merged 1 commit intoros2:rollingfrom
rahatchd:fix/wait-for-msg-ctx

Conversation

@rahatchd
Copy link
Copy Markdown
Contributor

@rahatchd rahatchd commented Jan 20, 2026

Description

  • use the context passed in to wait_for_message to construct wait set
    • this lets users use wait_for_message with custom ros context
  • add unit test for custom ros context

Fixes #3020

Is this user-facing behavior change?

  • users are able to use custom ros context with wait_for_message
  • previously users have to use global default context

Did you use Generative AI?

no

Additional Information

fujitatomoya
fujitatomoya approved these changes Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, i think this is inconsistent bug to manage context.

lgtm with green CI.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jan 21, 2026

@rahatchd can you fix DCO error?

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jan 21, 2026

Pulls: #3021
Gist: https://gist.githubusercontent.com/fujitatomoya/bae49577c927add9219975134a799d91/raw/aced9d55325344995a5492734267fe3ea318d8cf/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18005

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit cd86362 into ros2:rolling Jan 21, 2026
1 of 3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jan 21, 2026

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 21, 2026 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 21, 2026
@rahatchd @mergify
construct wait set with passed in context (#3021)
14f71f6 
(cherry picked from commit cd86362)
@mergify mergify bot mentioned this pull request Jan 21, 2026
Closed
mergify bot pushed a commit that referenced this pull request Jan 21, 2026
@rahatchd @mergify
construct wait set with passed in context (#3021)
5bb4c55 
(cherry picked from commit cd86362)
@mergify mergify bot mentioned this pull request Jan 21, 2026
Closed
mergify bot pushed a commit that referenced this pull request Jan 21, 2026
@rahatchd @mergify
construct wait set with passed in context (#3021)
52666d4 
(cherry picked from commit cd86362)
@mergify mergify bot mentioned this pull request Jan 21, 2026
Closed
mjcarroll added a commit that referenced this pull request Jan 21, 2026
@mjcarroll
Revert "construct wait set with passed in context (#3021)"
24b3ef7 
This reverts commit cd86362.
@mjcarroll mjcarroll mentioned this pull request Jan 21, 2026
Merged
fujitatomoya pushed a commit that referenced this pull request Jan 21, 2026
Revert "construct wait set with passed in context (#3021)" (#3028)
841a463 
This reverts commit cd86362.
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jan 21, 2026

@rahatchd this PR has been merged once, but we had to revert this because of no DCO signoff. can you recreate the another PR with DCO?

This was referenced Jan 22, 2026
Closed
Merged
@rahatchd
Copy link
Copy Markdown
Contributor Author

rahatchd commented Jan 22, 2026

@fujitatomoya fixed DCO here #3030

This was referenced Jan 22, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wait_for_message uses default ros context instead of passed node's context

3 participants

@rahatchd @fujitatomoya @ahcorde