Unified Node Interfaces: Add const version of get_node_x_interface() (backport #3006)#3010
Merged
Unified Node Interfaces: Add const version of get_node_x_interface() (backport #3006)#3010
Conversation
ahcorde
approved these changes
Dec 18, 2025
Contributor
|
Pulls: #3010
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This small PR adds a const version of get_node_x_interface() which returns a const shared pointer.
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
This addition is required when the
NodeInterfacesclass is a member of a class and one then would like to use theNodeInterfacesclass member in a const member function of that class to access at least const member functions of the separate node interfaces. Without this addition this is not possible at all andNodeInterfacesclass members can only be accessed in non-const member functions.It would also be great if this can be backported to older versions as well (especially in my case to Humble which gets just now the unified node interfaces backported with #3002).
This is an automatic backport of pull request #3006 done by Mergify.