Skip to content

correct test function descriptions (backport #2970)#2994

Merged
ahcorde merged 2 commits intohumblefrom
mergify/bp/humble/pr-2970
Nov 18, 2025
Merged

correct test function descriptions (backport #2970)#2994
ahcorde merged 2 commits intohumblefrom
mergify/bp/humble/pr-2970

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 18, 2025

Description

Current implementation doesn't allow publishing a shared_ptr, so some descriptions of test functions should be changed.

Fixes #2872

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes

Additional Information

This is an automatic backport of pull request #2970 done by [Mergify](https://mergify.com).

@Yuchen966 @mergify
correct test function descriptions (#2970)
95a6339 
Signed-off-by: Yuchen Liu <lyuchen9696@gmail.com>
(cherry picked from commit 354413c)

# Conflicts:
#	rclcpp/test/rclcpp/test_intra_process_manager.cpp
@mergify mergify bot added the conflicts label Nov 18, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Nov 18, 2025

Cherry-pick of 354413c has failed:

On branch mergify/bp/humble/pr-2970
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 354413c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/test_intra_process_manager.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Nov 18, 2025
Merged
@ahcorde
Fixed merge
681c9ba 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit b6238de into humble Nov 18, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-2970 branch November 18, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahcorde @Yuchen966