Skip to content

Reapply "Catch the exception from rate.sleep() if the context is inva…#2964

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/revert/pull/2963
Oct 6, 2025
Merged

Reapply "Catch the exception from rate.sleep() if the context is inva…#2964
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/revert/pull/2963

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

…lid. (#2956)" (#2963)

This reverts commit 6fbf039.

Description

Fixes # (issue)

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

…lid. (#2956)" (#2963)

This reverts commit 6fbf039.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Oct 6, 2025
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has bee approved with #2956.

I will start the CI for this.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

Pulls: #2964
Gist: https://gist.githubusercontent.com/fujitatomoya/ac7f37f1210c88b75fd48d84a06a7189/raw/4113e836b29f59b281e801d1f97a3a0c70dfd327/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17202

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

CI is green, i will merge this.

@fujitatomoya fujitatomoya merged commit cd9099d into rolling Oct 6, 2025
3 checks passed
iv461 pushed a commit to iv461/rclcpp that referenced this pull request Oct 7, 2025
…lid. (ros2#2956)" (ros2#2963) (ros2#2964)

This reverts commit 6fbf039.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant