Skip to content

Removed warning#2949

Merged
fujitatomoya merged 1 commit intorollingfrom
ahcorde/rolling/warning
Sep 11, 2025
Merged

Removed warning#2949
fujitatomoya merged 1 commit intorollingfrom
ahcorde/rolling/warning

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Sep 10, 2025

Related with this warning:

/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp:422:39: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
  422 |     RCUTILS_LOG_ERROR_NAMED("rclcpp", error_msg.c_str());
      |                                       ^~~~~~~~~~~~~~~~~
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:701:55: note: expanded from macro 'RCUTILS_LOG_ERROR_NAMED'
  701 |   RCUTILS_LOG_NAMED(RCUTILS_LOG_SEVERITY_ERROR, name, __VA_ARGS__)
      |                                                       ^~~~~~~~~~~
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:56:73: note: expanded from macro 'RCUTILS_LOG_NAMED'
   56 |       rcutils_log_internal(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
      |                                                                         ^~~~~~~~~~~
/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp:422:39: note: treat the string as an argument to avoid this
  422 |     RCUTILS_LOG_ERROR_NAMED("rclcpp", error_msg.c_str());
      |                                       ^
      |                                       "%s", 
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:701:55: note: expanded from macro 'RCUTILS_LOG_ERROR_NAMED'
  701 |   RCUTILS_LOG_NAMED(RCUTILS_LOG_SEVERITY_ERROR, name, __VA_ARGS__)
      |                                                       ^
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:56:73: note: expanded from macro 'RCUTILS_LOG_NAMED'
   56 |       rcutils_log_internal(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
      |                                                                         ^
/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp:445:39: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
  445 |     RCUTILS_LOG_ERROR_NAMED("rclcpp", error.c_str());
      |                                       ^~~~~~~~~~~~~
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:701:55: note: expanded from macro 'RCUTILS_LOG_ERROR_NAMED'
  701 |   RCUTILS_LOG_NAMED(RCUTILS_LOG_SEVERITY_ERROR, name, __VA_ARGS__)
      |                                                       ^~~~~~~~~~~
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:56:73: note: expanded from macro 'RCUTILS_LOG_NAMED'
   56 |       rcutils_log_internal(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
      |                                                                         ^~~~~~~~~~~
/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp:445:39: note: treat the string as an argument to avoid this
  445 |     RCUTILS_LOG_ERROR_NAMED("rclcpp", error.c_str());
      |                                       ^
      |                                       "%s", 
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:701:55: note: expanded from macro 'RCUTILS_LOG_ERROR_NAMED'
  701 |   RCUTILS_LOG_NAMED(RCUTILS_LOG_SEVERITY_ERROR, name, __VA_ARGS__)
      |                                                       ^
/home/ahcorde/ros2_rolling/install/include/rcutils/rcutils/logging_macros.h:56:73: note: expanded from macro 'RCUTILS_LOG_NAMED'
   56 |       rcutils_log_internal(&__rcutils_logging_location, severity, name, __VA_ARGS__); \

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 10, 2025
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Sep 10, 2025

Pulls: #2949
Gist: https://gist.githubusercontent.com/ahcorde/f2fe13a2cee904c9e21af166e4c121e6/raw/6ed23347c2f09926028d6e8cacd18f461cdfc9c7/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16926

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

RHEL failures are unrelated, i will go ahead to merge this.

Note that this is only for rolling.

@fujitatomoya fujitatomoya merged commit b432df1 into rolling Sep 11, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/warning branch September 11, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants