Skip to content

Removed warning test_qos#2859

Merged
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/warning_qos_test
May 26, 2025
Merged

Removed warning test_qos#2859
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/warning_qos_test

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented May 26, 2025

@ahcorde
Removed warning test_qos
bf6d187 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this May 26, 2025
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented May 26, 2025 •
edited
Loading

Pulls: #2859
Gist: https://gist.githubusercontent.com/ahcorde/174e9f867c588077d6c0323da6457285/raw/ad5d55aaa7e431cabf1fb612f09540b58210f1a1/ros2.repos
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16084

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

jmachowinski
jmachowinski reviewed May 26, 2025
View reviewed changes
rclcpp/test/rclcpp/test_qos.cpp Outdated
memset(&invalid_qos, 0, sizeof(invalid_qos));
reinterpret_cast<uint32_t &>(invalid_qos.history) = 999;
unsigned int n = 999;
memcpy(&invalid_qos.history, &n, sizeof(unsigned int));
Copy link
Copy Markdown
Collaborator

@jmachowinski jmachowinski May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
memcpy(&invalid_qos.history, &n, sizeof(unsigned int));
memcpy(&invalid_qos.history, &n, sizeof(n));

Copy link
Copy Markdown
Collaborator

@jmachowinski jmachowinski May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, I somehow merged this suggestion... That was actually not my intention...

@jmachowinski
Update rclcpp/test/rclcpp/test_qos.cpp
9f8a8f9 
Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented May 26, 2025

Pulls: #2859
Gist: https://gist.githubusercontent.com/ahcorde/174e9f867c588077d6c0323da6457285/raw/ad5d55aaa7e431cabf1fb612f09540b58210f1a1/ros2.repos
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16084

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit df3a303 into rolling May 26, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/warning_qos_test branch May 26, 2025 20:05
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Jun 12, 2025

https://github.com/Mergifyio backport kilted

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2025 •
edited
Loading

backport kilted

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jun 12, 2025
@ahcorde @mergify
Removed warning test_qos (#2859)
d82bed8 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit df3a303)
@mergify mergify bot mentioned this pull request Jun 12, 2025
Merged
ahcorde added a commit that referenced this pull request Jun 13, 2025
@mergify @ahcorde
Removed warning test_qos (#2859) (#2873)
160da7b 
(cherry picked from commit df3a303)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@Crola1702
Copy link
Copy Markdown
Contributor

Crola1702 commented Aug 6, 2025 •
edited
Loading

https://github.com/Mergifyio backport humble

(see warning on humble)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 6, 2025 •
edited
Loading

backport humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Aug 6, 2025
@ahcorde @mergify
Removed warning test_qos (#2859)
e03748f 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit df3a303)
@mergify mergify bot mentioned this pull request Aug 6, 2025
Merged
Crola1702 pushed a commit that referenced this pull request Aug 6, 2025
@ahcorde @Crola1702
Removed warning test_qos (#2859)
bd45284 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit df3a303)
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Crola1702 pushed a commit that referenced this pull request Aug 7, 2025
@mergify @ahcorde
Removed warning test_qos (#2859) (#2925)
76cdd45 
(cherry picked from commit df3a303)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@Crola1702
Copy link
Copy Markdown
Contributor

Crola1702 commented Sep 3, 2025

https://github.com/Mergifyio backport jazzy

(See warning on jazzy)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 3, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 3, 2025
@ahcorde @mergify
Removed warning test_qos (#2859)
7feee18 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit df3a303)
@mergify mergify bot mentioned this pull request Sep 3, 2025
Merged
fujitatomoya pushed a commit that referenced this pull request Sep 3, 2025
@mergify @ahcorde
Removed warning test_qos (#2859) (#2945)
0601de2 
(cherry picked from commit df3a303)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmachowinski jmachowinski jmachowinski approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @Crola1702 @jmachowinski