Update RingBufferImplementation to clear internal data.#2837
Update RingBufferImplementation to clear internal data.#2837fujitatomoya merged 2 commits intoros2:rollingfrom
Conversation
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp
Outdated
Show resolved
Hide resolved
…ntation.hpp Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
@InvincibleRMC thanks for taking care of this. lgtm with green CI.
@alsora can you also take a look if you have time?
|
Pulls: #2837
|
christophebedard
left a comment
There was a problem hiding this comment.
LGTM. One thing to note is that (I believe) clear() might not ever be used/called.
Yeah that is what I saw as well. |
|
Started a new build as it looks like Tomoya's one had some infrastructure issues
|
|
CI failures are unrelated. i see https://ci.ros2.org/job/ci_linux/23410/testReport/junit/sros2.test.sros2.commands.security.verbs/test_generate_policy/test_generate_policy/ (zenoh) issue a lot recently from CI. maybe we can create tracking issue and address it. |
Closes #2817