Expanded docstring of get_rmw_qos_profile()#2787
Merged
fujitatomoya merged 2 commits intoros2:rollingfrom Mar 30, 2025
abhishek47kashyap:rolling
Merged
Expanded docstring of get_rmw_qos_profile()#2787fujitatomoya merged 2 commits intoros2:rollingfrom abhishek47kashyap:rolling
get_rmw_qos_profile()#2787fujitatomoya merged 2 commits intoros2:rollingfrom
abhishek47kashyap:rolling
Conversation
Signed-off-by: Abhishek Kashyap <abhishek47kashyap@gmail.com>
Signed-off-by: Abhishek Kashyap <abhishek47kashyap@gmail.com>
christophebedard
approved these changes
Mar 30, 2025
Member
|
Pulls: #2787
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #2777
This PR makes the docstring for
QoS::get_rmw_qos_profile()more informative by describing what is meant by a profile, as described at Quality of Service settings.Unsure what information related to
rmwwould be pertinent here 🤔