should pull valid transition before trying to change the state. (backport #2774)#2784
Merged
should pull valid transition before trying to change the state. (backport #2774)#2784
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7b6ee8a)
Contributor
|
Pulls: #2784
|
ahcorde
approved these changes
Mar 28, 2025
jplapp
pushed a commit
to pixel-robotics/rclcpp
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i think this is just a simple oversight.
rcl_lifecycle_get_transition_by_idshould be called to pull out the valid transition based on the current state, aligns withrcl_lifecycle_get_transition_by_label.Note
backport to humble and jazzy required
This is an automatic backport of pull request #2774 done by Mergify.