Skip to content

fix: make the loop condition align with the description#2726

Merged
fujitatomoya merged 1 commit intoros2:rollingfrom
YuanYuYuan:fix/notifyTwiceWhileSpinning
Jan 14, 2025
Merged

fix: make the loop condition align with the description#2726
fujitatomoya merged 1 commit intoros2:rollingfrom
YuanYuYuan:fix/notifyTwiceWhileSpinning

Conversation

@YuanYuYuan
Copy link
Copy Markdown
Contributor

This failure happens sporadically when developing rmw_zenoh. This PR aims to correct the test behavior.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2726
Gist: https://gist.githubusercontent.com/fujitatomoya/71258eedfba5166a6e3086d5ef6307b5/raw/3cf92a6965b19546d4c17a19c07f15a8bde463c5/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15052

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@YuanYuYuan can you fix the DCO error?

Signed-off-by: yuanyuyuan <az6980522@gmail.com>
@YuanYuYuan YuanYuYuan force-pushed the fix/notifyTwiceWhileSpinning branch from 34bdd37 to 7a3f918 Compare January 14, 2025 07:35
@YuanYuYuan
Copy link
Copy Markdown
Contributor Author

@YuanYuYuan can you fix the DCO error?

Sure. Fixed 😃

@fujitatomoya fujitatomoya merged commit 2d1b770 into ros2:rolling Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants