Skip to content

Collect log messages from rcl, and reset.#2720

Merged
fujitatomoya merged 3 commits intorollingfrom
fujitatomoya/collect-more-rcl-log-message
Jan 8, 2025
Merged

Collect log messages from rcl, and reset.#2720
fujitatomoya merged 3 commits intorollingfrom
fujitatomoya/collect-more-rcl-log-message

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Dec 31, 2024

minor cosmetic fixes, if rcl interfaces fail, we should collect log messages that are set from rcl and reset the error message buffer.

@fujitatomoya
Collect log messages from rcl, and reset.
00ccdc5 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Dec 31, 2024
@fujitatomoya
call rcl_reset_error once the error message is collected.
43c5b50 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Jan 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses basically 2 things.

  • if rcl interface failed, pass the logging messages stored in rcl layer to client layer. (more logging information why rcl failed.)
  • makes sure resetting error storage once logging message is retrieved by such as logger and exception to the user.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 2, 2025 •
edited
Loading

Pulls: #2720
Gist: https://gist.githubusercontent.com/fujitatomoya/6820b9fdae6e215e53cd8bed90341ed9/raw/eca310bb661da421bc9c0a069a7835d684ffcf2e/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp rclcpp_action rclcpp_lifecycle
TEST args: --packages-above rclcpp rclcpp_action rclcpp_lifecycle
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Barry-Xu-2018
Copy link
Copy Markdown
Collaborator

Barry-Xu-2018 commented Jan 2, 2025

LGTM

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 4, 2025 •
edited
Loading

Pulls: #2720
Gist: https://gist.githubusercontent.com/fujitatomoya/207ceb117dfdd80265e4f6ee054a8fb5/raw/eca310bb661da421bc9c0a069a7835d684ffcf2e/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp rclcpp_action rclcpp_lifecycle
TEST args: --packages-above rclcpp rclcpp_action rclcpp_lifecycle
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15030

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
address CI failure, error is already collected and reset.
ee6357f 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/collect-more-rcl-log-message branch from f7ea441 to ee6357f Compare January 4, 2025 22:19
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 5, 2025

@Barry-Xu-2018 can you review again?

Barry-Xu-2018
Barry-Xu-2018 reviewed Jan 7, 2025
View reviewed changes
@Barry-Xu-2018
Copy link
Copy Markdown
Collaborator

Barry-Xu-2018 commented Jan 8, 2025

I have no more comments.
LGTM

@fujitatomoya fujitatomoya merged commit 9cabd69 into rolling Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Barry-Xu-2018 Barry-Xu-2018 Barry-Xu-2018 approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @Barry-Xu-2018