fix TestTimeSource.ROS_time_valid_attach_detach.#2700
Merged
fujitatomoya merged 1 commit intorollingfrom Dec 9, 2024
Merged
Conversation
fujitatomoya
commented
Dec 7, 2024
Collaborator
Author
fujitatomoya
left a comment
There was a problem hiding this comment.
@clalancette @ahcorde minor test fix, can you take a look?
Collaborator
Author
|
Pulls: #2700
|
clalancette
requested changes
Dec 7, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fb799e6 to
ee05c98
Compare
Collaborator
Author
|
CI:
|
Collaborator
Author
|
@clalancette friendly ping |
clalancette
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
TestTimeSource.ROS_time_valid_attach_detacherror message below.This test is expected to call
detachClockwith valid operation to remove the clock successfully.colcon test --event-handlers console_direct+ --packages-select rclcpp --ctest-args -R test_time_source ... 89: [ RUN ] TestTimeSource.ROS_time_valid_attach_detach 89: [ERROR] [1733531284.881187504] [rclcpp]: failed to remove clock 89: [ OK ] TestTimeSource.ROS_time_valid_attach_detach (4 ms) ...colcon test --event-handlers console_direct+ --packages-select rclcpp --ctest-args -R test_time_source ... 89: [ RUN ] TestTimeSource.ROS_time_valid_attach_detach 89: [ OK ] TestTimeSource.ROS_time_valid_attach_detach (4 ms) ...