Skip rmw zenoh content filtering tests#2627
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Is the segfault on the rmw_zenoh side or here? Either way we should ensure we don't segfault anywhere and instead throw appropriate errors? 🤔 |
|
@ahcorde do we still need this PR given the fix from ros2/rmw_zenoh#282? |
Now I'm getting a different error: [ RUN ] TestContentFilterSubscription.content_filter_reset
[WARN] [1727092853.470390122] [rmw_zenoh_cpp]: `reliability` no longer supported on subscriber. Ignoring...
/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_subscription_content_filter.cpp:293: Failure
Value of: receive
Actual: false
Expected: true
/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_subscription_content_filter.cpp:200: Failure
Expected equality of these values:
original_message
Which is: 48-byte object <00-00 00-CE 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 03-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>
output_message
Which is: 48-byte object <00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00> |
|
Ah a different error; likely from the fact that we don't implement content filtering in |
|
Pulls: #2627
|
|
Pulls: #2627
|
Content filtering is still not implemented in
rmw_zenohhttps://github.com/ros2/rmw_zenoh/blob/60b72f07a7d7254aeed8c39c11174bb52806ee62/rmw_zenoh_cpp/src/rmw_zenoh.cpp#L1690-L1713
These tests generates a segfault, I think we can skip them for now.