Skip to content

Correct node name in service test code#2615

Merged
ahcorde merged 1 commit intoros2:rollingfrom
Barry-Xu-2018:review/topic-fix-service-test-bug
Sep 2, 2024
Merged

Correct node name in service test code#2615
ahcorde merged 1 commit intoros2:rollingfrom
Barry-Xu-2018:review/topic-fix-service-test-bug

Conversation

@Barry-Xu-2018
Copy link
Copy Markdown
Collaborator

Fix a minor bug in service test.

Signed-off-by: Barry Xu <barry.xu@sony.com>
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2615
Gist: https://gist.githubusercontent.com/fujitatomoya/c9097f65bc96d398a173f91e3960dd7e/raw/3e4842c2aa980570843d5a3b8a830dcae1959c7e/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14498

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e846f56 into ros2:rolling Sep 2, 2024
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Sep 2, 2024

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2024

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit e846f56)
ahcorde pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit e846f56)

Co-authored-by: Barry Xu <barry.xu@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants