Implement callback support of async_send_request for service generic client#2614
Merged
ahcorde merged 3 commits intoros2:rollingfrom Oct 4, 2024
Merged
Conversation
…client Signed-off-by: Barry Xu <barry.xu@sony.com>
ahcorde
requested changes
Aug 29, 2024
Signed-off-by: Barry Xu <barry.xu@sony.com>
Contributor
|
@fujitatomoya would you be willing to give this one another review? 🧇 |
fujitatomoya
approved these changes
Sep 18, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Collaborator
|
@ahcorde could you have a 2nd review? |
Collaborator
|
Pulls: #2614
|
Collaborator
Author
|
Missing this information
I will fix this window issue. |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Collaborator
Author
|
Re-run CI on Windows
|
Contributor
|
ahcorde
approved these changes
Sep 27, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the implementation of
async_send_requestfor the GenericClient lacks support for callbacks.When a response is received, the user-defined callback can be automatically invoked.