Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
| }; | ||
|
|
||
| TYPED_TEST_SUITE(TestTimersLifecycle, ExecutorTypes); | ||
| TYPED_TEST_SUITE(TestTimersLifecycle, ExecutorTypes, ); |
There was a problem hiding this comment.
why this change? is it a typo?
There was a problem hiding this comment.
no, it's another clang warning
There was a problem hiding this comment.
I think we want to add ExecutorTypeNames instead?
| TYPED_TEST_SUITE(TestTimersLifecycle, ExecutorTypes, ); | |
| TYPED_TEST_SUITE(TestTimersLifecycle, ExecutorTypes, ExecutorTypeNames); |
There was a problem hiding this comment.
It's specifically for: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1986/gcc/folder.-1649941887/fileName.-411323968/
must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments] 35 | TYPED_TEST_SUITE(TestTimersLifecycle, ExecutorTypes); | ^
adding a comma (and nothing afterwards) does not change the behaviour and satisfies clang.
There was a problem hiding this comment.
I agree with @fujitatomoya , the correct approach is to pass ExecutorTypeNames there.
|
@ahcorde it looks like the Rpr job is failing in the test that you modified. |
|
Removed clang warnings related to this job https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1986/gcc/folder.-1649941887/
Introduced in this PR #2598