remove unnecessary gtest-skip in test_executors#2600
Merged
Conversation
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Collaborator
Author
|
fujitatomoya
approved these changes
Aug 19, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a couple of GTEST_SKIP instances from
test_executors.cpp.spin_some_max_durationtest is still broken for the static single threaded executor (despite max_duration not respected in spin_some for StaticSingleThreadedExecutor and EventsExecutor #2462 (comment)). Here I replaced theGTEST_SKIPwith theTestExecutorsStablefixture.test_race_condition_add_nodesucceeds with connext dds and events-executor (now that the events executor is supported by that RMW). Here I removed theGTEST_SKIP.