fix rclcpp/test/rclcpp/CMakeLists.txt to check for the correct targets#2596
Merged
fix rclcpp/test/rclcpp/CMakeLists.txt to check for the correct targets#2596
Conversation
…s existance Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
clalancette
approved these changes
Aug 5, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
fujitatomoya
approved these changes
Aug 5, 2024
Collaborator
|
CI:
|
Collaborator
Author
|
Merging with 3 approvals and green CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake file is checking if
ament_add_gtesthas effectively added any target (which is not guaranteed).However, probably due to some copy-paste errors, all the executors tests were checking for the same target.
This had no practical difference right nkw, since if one target exist we should assume that they all exist, but it was not correct.
Indeed if the
test_executorswould be removed, all the other tests would fail to compile.