subscriber_statistics_collectors_ should be protected by mutex.#2592
Merged
fujitatomoya merged 2 commits intorollingfrom Aug 9, 2024
Merged
subscriber_statistics_collectors_ should be protected by mutex.#2592fujitatomoya merged 2 commits intorollingfrom
fujitatomoya merged 2 commits intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Jul 30, 2024
rclcpp/test/rclcpp/topic_statistics/test_subscription_topic_statistics.cpp
Show resolved
Hide resolved
ahcorde
approved these changes
Jul 31, 2024
Contributor
|
clalancette
requested changes
Jul 31, 2024
rclcpp/include/rclcpp/topic_statistics/subscription_topic_statistics.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
CI:
|
clalancette
approved these changes
Aug 1, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Collaborator
Author
|
https://ci.ros2.org/job/ci_windows/22359/ are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor bug fix.
@clalancette can you take a look at this?