Merged
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Member
|
There's another |
Member
|
Here too: rclcpp/rclcpp/test/rclcpp/test_node.cpp Line 59 in 57858c5 |
Member
|
Another: |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
christophebedard
requested changes
Jul 11, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Contributor
Author
|
clalancette
requested changes
Jul 12, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
One more thing I think we should change.
clalancette
approved these changes
Jul 12, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
This looks good to me with green CI (it doesn't even technically need to wait for ros2/rcpputils#196 to be merged).
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
christophebedard
approved these changes
Jul 16, 2024
Member
christophebedard
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
clalancette
approved these changes
Jul 22, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR ros2/rcpputils#196
Updated deprecated API