LifecycleNode bugfix and add test cases#2562
Merged
fujitatomoya merged 4 commits intorollingfrom Sep 12, 2024
Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Currently it is user application responsibility to manage the all state control. See more details for #2520. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
@clalancette can you take a look? this is one of the follow-up, actually minor bug fix, debug print and test cases for LifecycleNode. |
fujitatomoya
commented
Jun 12, 2024
Collaborator
Author
|
@clalancette @mjcarroll friendly ping, can you take a look when you have time? |
tonynajjar
reviewed
Jun 21, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
either @clalancette or @mjcarroll can you please take a look before starting CI? |
Collaborator
Author
|
@alsora can you have a 2nd review for this? |
alsora
reviewed
Aug 27, 2024
alsora
approved these changes
Aug 27, 2024
Collaborator
alsora
left a comment
There was a problem hiding this comment.
Looks good to me!
Sorry if I missed this
- Linux
- Linux-aarch64
- Linux-rhel
- Windows
This was referenced Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up from #2520 (comment)
this can be backported to jazzy, iron and humble. (expecting conflict for iron and humble since type description is not available.)