Skip to content

revert call shutdown in LifecycleNode destructor (Humble)#2560

Merged
fujitatomoya merged 2 commits intohumblefrom
fujitatomoya/revert-shutdown-in-lcnode-dtor-humble
Jun 12, 2024
Merged

revert call shutdown in LifecycleNode destructor (Humble)#2560
fujitatomoya merged 2 commits intohumblefrom
fujitatomoya/revert-shutdown-in-lcnode-dtor-humble

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Jun 10, 2024

revert #2544 and #2491

@fujitatomoya
Revert "lifecycle node dtor shutdown should be called only in primary…
adf6b47 
… state. (#2544)"

This reverts commit 595badb.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Revert "call shutdown in LifecycleNode dtor to avoid leaving the devi…
d3461a9 
…ce in un… (#2450) (#2491)"

This reverts commit 0f9604d.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 10, 2024 •
edited
Loading

CI (--packages-above-and-dependencies rclcpp_lifecycle):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Jun 10, 2024
Merged
Closed
@fujitatomoya fujitatomoya self-assigned this Jun 10, 2024
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 11, 2024

hmmm, Linux-RHEL is not stable... i will give it a shot probably later.

12:03:13 java.nio.channels.ClosedChannelException

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Jun 11, 2024

hmmm, Linux-RHEL is not stable... i will give it a shot probably later.

It's already rebuilding as https://ci.ros2.org/job/ci_linux-rhel/735/ . You are just getting unlucky here for some reason. If it happens yet again, I'll ask the infrastructure team to look into it.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 11, 2024

it is likely that i can see CI RHEL hung up with ros2cli ...

image

https://ci.ros2.org/job/ci_linux-rhel/733/console has the same situation.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 11, 2024

CI (test --packages-above-and-dependencies rclcpp_lifecycle --packages-skip ros2cli)

  • Linux-rhel Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 12, 2024 •
edited
Loading

CI (test --packages-above-and-dependencies rclcpp_lifecycle --packages-above-depth 1)

  • Linux-rhel Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 12, 2024

ignoring CI RHEL for humble for now because it is not stable, all other CIs are green, i will go ahead to merge this.

@fujitatomoya fujitatomoya merged commit 6737773 into humble Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @clalancette @wjwwood