revert call shutdown in LifecycleNode destructor (Iron)#2559
Merged
fujitatomoya merged 2 commits intoironfrom Jun 11, 2024
Merged
revert call shutdown in LifecycleNode destructor (Iron)#2559fujitatomoya merged 2 commits intoironfrom
fujitatomoya merged 2 commits intoironfrom
Conversation
fujitatomoya
commented
Jun 10, 2024
| node_timers_.reset(); | ||
| node_logging_.reset(); | ||
| node_graph_.reset(); | ||
| node_base_.reset(); |
Collaborator
Author
There was a problem hiding this comment.
this is a bug fix, i wil resubmit this fix after reverting.
| } | ||
|
|
||
|
|
||
| TEST_F(TestDefaultStateMachine, shutdown_from_each_primary_state) { |
Collaborator
Author
There was a problem hiding this comment.
same with rolling, this is test enhancement. i will resubmit this later.
Collaborator
Author
|
CI (
|
This was referenced Jun 10, 2024
wjwwood
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert #2543 and #2490