lifecycle node dtor shutdown should be called only in primary state.#2544
Merged
fujitatomoya merged 2 commits intohumblefrom Jun 6, 2024
Merged
lifecycle node dtor shutdown should be called only in primary state.#2544fujitatomoya merged 2 commits intohumblefrom
fujitatomoya merged 2 commits intohumblefrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
CI:
|
Collaborator
Author
|
please do not merge this yet, i think we need to add #2545. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
CI:
|
Collaborator
Author
|
windows failure is unrelated, https://ci.ros2.org/job/ci_windows/21919/ |
fujitatomoya
added a commit
that referenced
this pull request
Jun 12, 2024
* Revert "lifecycle node dtor shutdown should be called only in primary state. (#2544)" This reverts commit 595badb. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Revert "call shutdown in LifecycleNode dtor to avoid leaving the device in un… (#2450) (#2491)" This reverts commit 0f9604d. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick a3caf17