use allocator via init_options argument.#2129
Merged
fujitatomoya merged 1 commit intorollingfrom Mar 17, 2023
Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Mar 16, 2023
alsora
approved these changes
Mar 16, 2023
Collaborator
Author
|
@ros-pull-request-builder retest this please |
Collaborator
Author
|
CI:
|
iuhilnehc-ynos
approved these changes
Mar 17, 2023
clalancette
approved these changes
Mar 17, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Good catch, the allocator is being used before we initialize init_options_. Switching to the passed-in init_options fixes it.
Contributor
|
That said, I suggest we run CI with |
Collaborator
Author
|
@Mergifyio backport humble |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 1a796b5)
Collaborator
Author
|
@clalancette sorry i missed your comment, browser cache or something did not show it. i will start the CI as you suggested. |
Collaborator
Author
|
CI:
|
Collaborator
Author
|
all test passed but it show |
Collaborator
Author
|
I think build / test option was not correct.
|
Collaborator
Author
|
unstable failure is not related to this PR. |
fujitatomoya
added a commit
that referenced
this pull request
Mar 20, 2023
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclcpp
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of ros2/rcl#1036, but independent bug fix.