Fix clang warning: bugprone-use-after-move#2116
Merged
clalancette merged 1 commit intoros2:rollingfrom Mar 5, 2023
Merged
Conversation
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
mjcarroll
approved these changes
Mar 3, 2023
fujitatomoya
approved these changes
Mar 3, 2023
clalancette
approved these changes
Mar 4, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Yeah, this is a good idea. I'll kick off CI for it.
Contributor
|
CI:
|
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 28, 2023
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
otamachan
pushed a commit
to otamachan/rclcpp
that referenced
this pull request
Mar 20, 2024
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com>
otamachan
pushed a commit
to otamachan/rclcpp
that referenced
this pull request
Mar 20, 2024
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com>
otamachan
pushed a commit
to otamachan/rclcpp
that referenced
this pull request
Mar 20, 2024
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com> Signed-off-by: Tamaki Nishino <otamachan@gmail.com>
mjcarroll
pushed a commit
that referenced
this pull request
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix clang warning:
bugprone-use-after-movehttps://clang.llvm.org/extra/clang-tidy/checks/bugprone/use-after-move.html
The fix is explicitly break from a for loop after the final message has been delivered.
Even if it we know we will exit the for loop,since we check
rclcpp/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp
Line 454 in 399f4df
this is not enough for clang-tidy and it complains.