Add default constructor to NodeInterfaces#2094
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
| : interfaces_(init_tuple<decltype(node), InterfaceTs ...>(node)) | ||
| {} | ||
|
|
||
| NodeInterfacesStorage() // NOLINT(runtime/explicit) |
Contributor
There was a problem hiding this comment.
I think this NOLINT directive is not necesary. cpplint only enforces the usage of explicit for constructors with a single argument.
I tested it locally and the linters were happy with the NOLINT comment removed!
Suggested change
| NodeInterfacesStorage() // NOLINT(runtime/explicit) | |
| NodeInterfacesStorage() |
Contributor
|
alsora
approved these changes
Jan 30, 2023
Signed-off-by: Shane Loretz <sloretz@google.com>
fujitatomoya
approved these changes
Jan 30, 2023
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with @methylDragon comment resolved.
Contributor
Author
|
Since changes since full CI just remove a comment, I think only linter tests are needed. I'll merge if the Rpr job comes back green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a default constructor. This allows a class to have an
interfacesmember that get's populated by an argument to it's constructor.