Merged
Conversation
6c90c2b to
f7b3ab9
Compare
clalancette
requested changes
Nov 7, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I've left a couple of things to consider.
Comment on lines
-7
to
+9
| <maintainer email="ivanpauno@ekumenlabs.com">Ivan Paunovic</maintainer> | ||
| <maintainer email="jacob@openrobotics.org">Jacob Perron</maintainer> | ||
|
|
||
| <maintainer email="william@openrobotics.org">William Woodall</maintainer> | ||
| <maintainer email="ivanpauno@ekumenlabs.com">Ivan Paunovic</maintainer> | ||
| <maintainer email="michel@ekumenlabs.com">Michel Hidalgo</maintainer> |
Contributor
There was a problem hiding this comment.
The churn here is a little unfortunate; it would be nice if we didn't move Ivan, for instance. It's not blocking, but maybe it is something we can improve in the code that generates this.
Member
Author
There was a problem hiding this comment.
I forgot to sort alphabetically, now the churn is much less.
Signed-off-by: Audrow Nash <audrow@openrobotics.org>
Signed-off-by: Audrow Nash <audrow@openrobotics.org>
f7b3ab9 to
6d40678
Compare
clalancette
approved these changes
Nov 7, 2022
Member
Author
|
@ros-pull-request-builder retest this please |
alsora
approved these changes
Nov 8, 2022
clalancette
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the maintainers and code owners. The maintainers are:
This PR was made with https://github.com/audrow/update-ros2-repos.