fix a case that not throw ParameterUninitializedException#2036
Merged
fujitatomoya merged 5 commits intoros2:rollingfrom Nov 9, 2022
Merged
Conversation
Collaborator
Author
|
CI:
|
Collaborator
|
LGTM 👍 |
fujitatomoya
approved these changes
Oct 31, 2022
Collaborator
Author
|
I'd like to add an extra fix in this PR as it's related to the parameter. |
Collaborator
Author
|
run CI with more restrictive settings,
|
fujitatomoya
approved these changes
Nov 1, 2022
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm, but i request the review from @ivanpauno
added 4 commits
November 9, 2022 09:43
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
…ameters in service callback Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
6b696c5 to
690a92d
Compare
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Collaborator
Author
|
CI:
|
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
* fix a case that not throw ParameterUninitializedException Signed-off-by: Chen Lihui <lihui.chen@sony.com> * catch ParameterUninitializedException exception while calling get_parameters in service callback Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update doc Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add one more test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * explicitly use this to call a method inside the class itself Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
* fix a case that not throw ParameterUninitializedException Signed-off-by: Chen Lihui <lihui.chen@sony.com> * catch ParameterUninitializedException exception while calling get_parameters in service callback Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update doc Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add one more test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * explicitly use this to call a method inside the class itself Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
* fix a case that not throw ParameterUninitializedException Signed-off-by: Chen Lihui <lihui.chen@sony.com> * catch ParameterUninitializedException exception while calling get_parameters in service callback Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update doc Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add one more test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * explicitly use this to call a method inside the class itself Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
* fix a case that not throw ParameterUninitializedException Signed-off-by: Chen Lihui <lihui.chen@sony.com> * catch ParameterUninitializedException exception while calling get_parameters in service callback Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update doc Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add one more test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * explicitly use this to call a method inside the class itself Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix #2035 and #2038
Signed-off-by: Chen Lihui lihui.chen@sony.com