Skip to content

Set cpplint timeout to 3 mins#2022

Merged
Crola1702 merged 1 commit intorollingfrom
Crola1702/fix-cpplint-timeout
Oct 10, 2022
Merged

Set cpplint timeout to 3 mins#2022
Crola1702 merged 1 commit intorollingfrom
Crola1702/fix-cpplint-timeout

Conversation

@Crola1702
Copy link
Copy Markdown
Contributor

@Crola1702 Crola1702 commented Oct 7, 2022

Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com

Cpplint test is timing out on Windows machines.

  3/104 Test   #3: cpplint ................................................***Timeout 120.01 sec
line duration
3: - C:/ci/ws/install/Scripts/ament_cpplint.exe --xunit-file C:/ci/ws/build/rclcpp/test_results/rclcpp/cpplint.xunit.xml +6 seconds
3: Done processing C:\ci\ws\src\ros2\rclcpp\rclcpp\include\rclcpp\node_interfaces\node_time_source_interface.hpp File +6 seconds
03:51:30.157 3: Done processing C:\ci\ws\src\ros2\rclcpp\rclcpp\src\rclcpp\init_options.cpp File +4 seconds

Reference build: https://ci.ros2.org/view/nightly/job/nightly_win_deb/2503/

Running CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@Crola1702
Set cpplint timeout to 3 mins
fac2546 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Blast545
Copy link
Copy Markdown
Contributor

Blast545 commented Oct 7, 2022

@Crola1702 Wouldn't it be faster to test CI up-to rclcpp instead of the whole CI?

Blast545
Blast545 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after green CI.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Oct 7, 2022

The change is fine with me. That said, I don't want to have to make this change again soon. With this change in place, how long does cpplint for rclcpp take to run on Windows Debug?

@Crola1702
Copy link
Copy Markdown
Contributor Author

Crola1702 commented Oct 10, 2022

Unstable Windows CI related to known issue

@Crola1702 Crola1702 merged commit 3aca271 into rolling Oct 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the Crola1702/fix-cpplint-timeout branch October 10, 2022 13:17
@Crola1702
Copy link
Copy Markdown
Contributor Author

Crola1702 commented Oct 10, 2022

The change is fine with me. That said, I don't want to have to make this change again soon. With this change in place, how long does cpplint for rclcpp take to run on Windows Debug?

Sorry Chris, I didn't see your comment

With this change, it's taking 120.71 seconds. (The limit before was 120.00 seconds). I think we won't be changing this limit for a while.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Oct 10, 2022

With this change, it's taking 120.71 seconds. (The limit before was 120.00 seconds). I think we won't be changing this limit for a while.

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blast545 Blast545 Blast545 approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Crola1702 @Blast545 @clalancette @fujitatomoya