Cleanup the rclcpp_lifecycle dependencies.#2021
Merged
clalancette merged 1 commit intorollingfrom Oct 4, 2022
Merged
Conversation
That is, make sure they are all listed in package.xml, found in the CMakeLists.txt, and properly included where they are used. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
alsora
reviewed
Oct 4, 2022
| "lifecycle_msgs" | ||
| "rosidl_typesupport_cpp" | ||
| target_link_libraries(${PROJECT_NAME} | ||
| ${lifecycle_msgs_TARGETS} |
Collaborator
There was a problem hiding this comment.
unrelated, but is there any progress on being able to use modern CMake targets like lifecycle_msgs::lifecycle_msgs ?
Contributor
Author
There was a problem hiding this comment.
unrelated, but is there any progress on being able to do use modern CMake targets like lifecycle_msgs::lifecycle_msgs ?
Not that I know of. It needs someone to look at it more deeply; when we've tried in the past, it was more complicated than we thought (for reasons I don't remember right now).
alsora
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is, make sure they are all listed in package.xml, found in the CMakeLists.txt, and properly included where they are used.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
There should be no functional change from this PR; I just noticed all of this while reviewing other PRs touching the lifecycle stuff.