support regex match for parameter client#1992
Merged
fujitatomoya merged 4 commits intoros2:rollingfrom Sep 8, 2022
Merged
Conversation
Collaborator
|
@iuhilnehc-ynos there are conflicts on this PR, could you address it? and do we have issue or reference against this PR? |
60e2c8c to
0f42d78
Compare
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Collaborator
Author
No, I didn't create an issue. Thanks for mentioning it. I am going to create it. |
Collaborator
|
@iuhilnehc-ynos yeah it would be nice for reviewers to describe what exactly we are addressing to. it does not have to be issue, i think we can add description on this PR too. thanks! |
fujitatomoya
approved these changes
Aug 19, 2022
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm, can you run CI?
ivanpauno
reviewed
Aug 19, 2022
added 3 commits
August 20, 2022 11:01
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Collaborator
Author
|
CI:
|
Contributor
|
@iuhilnehc-ynos I think this is set to go, so feel free to merge when you are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to implement #1997
Signed-off-by: Chen Lihui lihui.chen@sony.com