[docs] add note about callback lifetime for {on, post}_set_parameter_callback#1981
Merged
[docs] add note about callback lifetime for {on, post}_set_parameter_callback#1981
Conversation
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
fujitatomoya
reviewed
Aug 4, 2022
jacobperron
reviewed
Aug 4, 2022
Member
jacobperron
left a comment
There was a problem hiding this comment.
I think the same message should also be added to add_pre_set_parameters_callback.
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been burned by ignoring the return value and so has a few others -- adding a note about the lifetime of the registered callback being tied to the returned callback handle further up the documentation should help others avoid making the same mistake.
Signed-off-by: Brian Chen brian.chen@openrobotics.org