Skip to content

Update get_parameter_from_event to follow the function description#1922

Merged
jacobperron merged 1 commit intoros2:masterfrom
Barry-Xu-2018:topic-fix-get_parameter_from_event
May 3, 2022
Merged

Update get_parameter_from_event to follow the function description#1922
jacobperron merged 1 commit intoros2:masterfrom
Barry-Xu-2018:topic-fix-get_parameter_from_event

Conversation

@Barry-Xu-2018
Copy link
Copy Markdown
Collaborator

Address #1921

Signed-off-by: Barry Xu <barry.xu@sony.com>
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Copy Markdown

@Treborsky Treborsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Copy Markdown
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants