Skip to content

fix bugprone-exception-escape in node_main.cpp.in#1895

Merged
alsora merged 1 commit intomasterfrom
asoragna/components-clang-tidy
Mar 8, 2022
Merged

fix bugprone-exception-escape in node_main.cpp.in#1895
alsora merged 1 commit intomasterfrom
asoragna/components-clang-tidy

Conversation

@alsora
Copy link
Copy Markdown
Collaborator

@alsora alsora commented Mar 7, 2022

Fixes #1890

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
@alsora alsora force-pushed the asoragna/components-clang-tidy branch from cc35ea3 to d4e2426 Compare March 7, 2022 22:45
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alsora
Copy link
Copy Markdown
Collaborator Author

alsora commented Mar 8, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@alsora
Copy link
Copy Markdown
Collaborator Author

alsora commented Mar 8, 2022

Warnings are unrelated and are happening also in other builds.
Merging this.

@alsora alsora merged commit f2f7ffd into master Mar 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the asoragna/components-clang-tidy branch March 8, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bugprone-exception-escape in node_main.cpp.in

2 participants