Skip to content

Use RCLCPP_LIFECYCLE_PUBLIC visibility macro in rclcpp_lifecycle package#1732

Merged
sloretz merged 1 commit intomasterfrom
for_each_callback_group_dll_linkage
Jul 28, 2021
Merged

Use RCLCPP_LIFECYCLE_PUBLIC visibility macro in rclcpp_lifecycle package#1732
sloretz merged 1 commit intomasterfrom
for_each_callback_group_dll_linkage

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Jul 28, 2021

Fixes #1731

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug Something isn't working label Jul 28, 2021
@sloretz sloretz self-assigned this Jul 28, 2021
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Jul 28, 2021

CI (build: --packages-up-to rclcpp_lifecycle test: --packages-select rclcpp_lifecycle)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Jul 28, 2021

CI LGTM, merging!

@sloretz sloretz merged commit 01f6ebd into master Jul 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the for_each_callback_group_dll_linkage branch July 28, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Inconsistent dll linkage with for_each_callback_group

3 participants