to create a sublogger while getting child of Logger#1717
to create a sublogger while getting child of Logger#1717clalancette merged 5 commits intoros2:rollingfrom
Conversation
fujitatomoya
left a comment
There was a problem hiding this comment.
a minor comment, but LGTM.
|
@iuhilnehc-ynos can you start CI with ros2/rcl#921? |
|
I need to re-check if the implementations are good or not, after that, I'll trigger the CI. |
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
bd4f5a3 to
67394c3
Compare
|
CI:
|
|
@clalancette @wjwwood i am good to go with this change, could you do another review? this needs to be aligned with ros2/rcl#921 |
|
The URL for Windows by https://ci.ros2.org/job/ci_launcher/11246/console seems incorrect (Maybe it's because rebuild the ci_launcher before https://ci.ros2.org/job/ci_launcher/11242/console, but the After checking the commit ID in Windows
|
|
@clalancette could you also review this? this depends on ros2/rcl#921, they must be merged together. |
clalancette
left a comment
There was a problem hiding this comment.
I've got one thing that I think can be simplified; otherwise, this looks pretty good to me.
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
clalancette
left a comment
There was a problem hiding this comment.
Two small fixes here, then I think this will be good.
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
|
@ros-pull-request-builder retest this please |
1 similar comment
|
@ros-pull-request-builder retest this please |
|
CI:
|
|
The single failed test on Windows is a known flake, so going ahead and merging this. |
use new APIs based on ros2/rcl#921
Signed-off-by: Chen Lihui lihui.chen@sony.com