-
Notifications
You must be signed in to change notification settings - Fork 522
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
We decided we wanted to do this (see discussion here: #1598 (comment)), but decided against doing it so close to the Galactic API freeze.
These are signatures in question:
rclcpp/rclcpp/include/rclcpp/any_subscription_callback.hpp
Lines 192 to 214 in 1037822
| /// Function for shared_ptr to non-const MessageT, which is deprecated. | |
| // TODO(wjwwood): enable this deprecation after Galactic | |
| // [[deprecated( | |
| // "use 'void (std::shared_ptr<const MessageT>)' instead" | |
| // )]] | |
| void | |
| set_deprecated(std::function<void(std::shared_ptr<MessageT>)> callback) | |
| // set(CallbackT callback) | |
| { | |
| callback_variant_ = callback; | |
| } | |
| /// Function for shared_ptr to non-const MessageT with MessageInfo, which is deprecated. | |
| // TODO(wjwwood): enable this deprecation after Galactic | |
| // [[deprecated( | |
| // "use 'void (std::shared_ptr<const MessageT>, const rclcpp::MessageInfo &)' instead" | |
| // )]] | |
| void | |
| set_deprecated( | |
| std::function<void(std::shared_ptr<MessageT>, const rclcpp::MessageInfo &)> callback) | |
| { | |
| callback_variant_ = callback; | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request