[foxy] Fix runtime error: reference binding to null pointer of type (#1547)#1548
Merged
fujitatomoya merged 1 commit intoros2:foxyfrom Feb 11, 2021
Merged
Conversation
Collaborator
Author
|
CI:
|
Collaborator
Author
|
@clalancette @wjwwood friendly ping |
clalancette
approved these changes
Feb 10, 2021
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me. @jacobperron FYI.
wjwwood
approved these changes
Feb 10, 2021
Member
|
Just making sure @fujitatomoya, but you based the CI off of the Foxy ros2.repos file yes? If so, I'd say it's good for merge. |
Collaborator
Author
that is yes, based on https://github.com/ros2/ros2/blob/foxy/ros2.repos. thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foxy backport of #1547 (original issue is #1544)