Conversation
…(), mark no except (#1297) * Catch potential exception in destructor and log Signed-off-by: Stephen Brawner <brawner@gmail.com> * Remove thrown error from reset and mark it no except Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
@jacobperron should I just backport the fix and not the API change? (marking reset() here noexcept) |
jacobperron
approved these changes
Oct 5, 2020
Member
|
@ros-pull-request-builder retest this please |
Member
Good question. It isn't clear to me if it is guaranteed to be ABI compatible. Perhaps it is safest to remove the |
jacobperron
requested changes
Oct 5, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
jacobperron
approved these changes
Oct 5, 2020
Contributor
Author
|
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1297 for foxy