Skip to content

rclcpp::Time and rclcpp::Duration max values not near max int64_t #1351

@Blast545

Description

@Blast545

Follow up Issue to track the conversation in #1347 (comment)

Basically this is to consider a new approach to the one agreed on #538. The max method for Time and Duration IMO should return the max value of the representation in nanoseconds.

Not sure if that was a constrain in the past, but the sum / substraction operators can handle properly overflow and underflow operations, so I don't see any reason to limit the max value returned by the max method.

If this is not a desired approach, an update to the header of the function will be required, as it stated \return the maximum representable value which is not the case.

Tagging @clalancette for awareness

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions