Skip to content

(dashing) Add operator!= to Duration#1277

Merged
ivanpauno merged 1 commit intodashingfrom
ivanpauno/dashing-duration-neq
Aug 18, 2020
Merged

(dashing) Add operator!= to Duration#1277
ivanpauno merged 1 commit intodashingfrom
ivanpauno/dashing-duration-neq

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno commented Aug 14, 2020

Backports #1236.

This is an addition, not a bug fix.
It makes sense to me to backport this for consistency. It's weird to have all comparison operators except !=.

@ivanpauno
add operator!= for duration (#1236)
a966214 
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Aug 14, 2020
@ivanpauno ivanpauno self-assigned this Aug 14, 2020
@ivanpauno ivanpauno mentioned this pull request Aug 14, 2020
Merged
audrow
audrow approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@audrow audrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the build passing.

@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Aug 18, 2020

@ros-pull-request-builder retest this please

@ivanpauno ivanpauno merged commit c214ddc into dashing Aug 18, 2020
@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Aug 18, 2020

I clicked the squash-and-merge button. The merge failed and the PR was still open.
Some minutes after I clicked again, it worked.

The result, two commits (the second one with an empty diff):

Github is working quite well 😮

@ivanpauno ivanpauno deleted the ivanpauno/dashing-duration-neq branch August 18, 2020 13:38
iluetkeb pushed a commit to boschresearch/ros2_rclcpp that referenced this pull request May 4, 2021
@ivanpauno
add operator!= for duration (ros2#1236) (ros2#1277)
d27ca8e 
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jannik Abbenseth <ipa-jba@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@audrow audrow audrow approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees

@ivanpauno ivanpauno

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpauno @audrow @nuclearsandwich