Simplify and fix allocator memory strategy unit test for connext#1252
Merged
Simplify and fix allocator memory strategy unit test for connext#1252
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a difference between connext and other rmw implementations, this unit test was failing. I decided to modify this test so that all callback groups are set so
group->can_be_taken_from()is set to false before adding one callback group and the associated entities. This let me remove the logic that tracks how many entities are in the basic nodes, since the memory strategy will only ever find those that belong to the callback_group that can be taken from.Failing example:
https://ci.ros2.org/job/ci_linux/11735/testReport/junit/projectroot/test/test_allocator_memory_strategy/
FastRTPS (plus others)
Connext only:
Signed-off-by: Stephen Brawner brawner@gmail.com