[foxy backport] Warn about unused result of add_on_set_parameters_callback (#1238)#1244
Merged
jacobperron merged 1 commit intofoxyfrom Aug 3, 2020
Merged
[foxy backport] Warn about unused result of add_on_set_parameters_callback (#1238)#1244jacobperron merged 1 commit intofoxyfrom
jacobperron merged 1 commit intofoxyfrom
Conversation
If the user doesn't retain a reference to the returned shared pointer there will be zero references and their callback will be unregistered. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
approved these changes
Aug 3, 2020
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, normally wouldn't add a warning, but it is fixing a bug in the usage imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1238 to Foxy
If the user doesn't retain a reference to the returned shared pointer there will be zero references and their callback will be unregistered.