[eloquent backport] Warn about unused result of add_on_set_parameters_callback (#1238)#1243
Merged
jacobperron merged 1 commit intoeloquentfrom Dec 2, 2020
Merged
Conversation
If the user doesn't retain a reference to the returned shared pointer there will be zero references and their callback will be unregistered. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
The ABI checker is failing, but I'm pretty sure it is unrelated to the changes in this PR. |
Member
Yeah, that isn't related. |
jacobperron
added a commit
to ros2/ros2_documentation
that referenced
this pull request
Dec 1, 2020
Relates to ros2/rclcpp#1243. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Member
Author
|
@ivanpauno I've added a note to the Eloquent release page ros2/ros2_documentation#933 cc/ @mjcarroll |
ivanpauno
approved these changes
Dec 2, 2020
jacobperron
added a commit
to ros2/ros2_documentation
that referenced
this pull request
Dec 2, 2020
Relates to ros2/rclcpp#1243. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ferranm99
added a commit
to ferranm99/ferran-ros
that referenced
this pull request
May 20, 2022
Relates to ros2/rclcpp#1243. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1238 to Eloquent.
If the user doesn't retain a reference to the returned shared pointer there will be zero references and their callback will be unregistered.