Added missing tests for rclcpp lifecycle#1240
Merged
Conversation
- remove_on_set_parameters_callback - notify_graph_change - get_service_names_and_types_by_node Signed-off-by: ahcorde <ahcorde@gmail.com>
Contributor
Author
|
brawner
reviewed
Jul 27, 2020
| { | ||
| auto node = std::make_shared<LifecycleServiceClient>("client_wait_for_graph_change"); | ||
| auto * node_graph = | ||
| dynamic_cast<rclcpp::node_interfaces::NodeGraph *>(node->get_node_graph_interface().get()); |
Contributor
There was a problem hiding this comment.
Is the dynamic_cast necessary?
Contributor
Author
There was a problem hiding this comment.
I copy this line from the original test
rclcpp/rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp
Lines 47 to 48 in 7e68d35
Contributor
There was a problem hiding this comment.
That test was for node_interfaces explicitly, and I wanted to verify that the cast to NodeGraph* was doing what I thought it was.
I think for this test, the std::shared_ptr<NodeGraphInterface> from get_node_graph_interface() should be sufficient.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
reviewed
Jul 28, 2020
brawner
reviewed
Jul 28, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Contributor
Author
|
brawner
approved these changes
Aug 10, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
Sorry this review slipped through the cracks
| EXPECT_EQ(transitions.size(), 0u); | ||
| } | ||
|
|
||
|
|
Contributor
Author
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
3b4bfba to
49dd1bd
Compare
peterpena
pushed a commit
that referenced
this pull request
Aug 18, 2020
* Added missing test rclcpp lifecycle - remove_on_set_parameters_callback - notify_graph_change - get_service_names_and_types_by_node Signed-off-by: ahcorde <ahcorde@gmail.com> * omit the name of the argument in lambda function Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Removed extra line Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Oct 22, 2020
* Added missing test rclcpp lifecycle - remove_on_set_parameters_callback - notify_graph_change - get_service_names_and_types_by_node Signed-off-by: ahcorde <ahcorde@gmail.com> * omit the name of the argument in lambda function Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Removed extra line Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Nov 3, 2020
* Added missing test rclcpp lifecycle - remove_on_set_parameters_callback - notify_graph_change - get_service_names_and_types_by_node Signed-off-by: ahcorde <ahcorde@gmail.com> * omit the name of the argument in lambda function Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Removed extra line Signed-off-by: ahcorde <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this https://ci.ros2.org/job/nightly_linux_coverage/lastBuild/cobertura/src_ros2_rclcpp_rclcpp_lifecycle_src/lifecycle_node_cpp/lifecycle_node_cpp/
Signed-off-by: ahcorde ahcorde@gmail.com