Skip to content

Fix test_lifecycle_node.cpp:check_parameters#1136

Merged
ivanpauno merged 2 commits intomasterfrom
ivanpauno/fix-failure-lifecycle-node-param-callback-test
May 27, 2020
Merged

Fix test_lifecycle_node.cpp:check_parameters#1136
ivanpauno merged 2 commits intomasterfrom
ivanpauno/fix-failure-lifecycle-node-param-callback-test

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

No description provided.

ivanpauno added 2 commits May 27, 2020 16:07
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added bug Something isn't working in review Waiting for review (Kanban column) labels May 27, 2020
@ivanpauno ivanpauno self-assigned this May 27, 2020
Copy link
Copy Markdown
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me (with green CI)

Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented May 27, 2020

CI:

@ivanpauno ivanpauno merged commit eff11d6 into master May 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-failure-lifecycle-node-param-callback-test branch May 27, 2020 19:59
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Jul 7, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants