Merged
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
clalancette
approved these changes
May 8, 2020
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I saw the same thing yesterday, I just didn't get a chance to open a PR. Looks good to me with green(ish) CI.
Contributor
Author
|
Contributor
Author
|
That test failure on OSX is unrelated and happens on the nightlies as well. |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a deprecation warning when building on OSX.